Skip to content

Conversation

wugeer
Copy link
Contributor

@wugeer wugeer commented Dec 31, 2024

@wugeer wugeer force-pushed the feat/add_suppor_days_etc branch from 5729338 to f8b32e6 Compare December 31, 2024 15:13
@iffyio iffyio changed the title add time unit SECONDS/MINUTES/HOURS/DAYS/WEEKS/MONTHS/YEARS for `IN… Support pluralized time units Jan 5, 2025
@wugeer wugeer requested a review from iffyio January 6, 2025 13:56
@wugeer wugeer requested a review from iffyio January 7, 2025 15:10
@wugeer wugeer requested a review from iffyio January 8, 2025 13:35
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wugeer!
cc @alamb

@iffyio iffyio merged commit 62bcaa1 into apache:main Jan 8, 2025
9 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 8, 2025

Wow we have really been picking up steam on reviews in sqlparser. The next relaese is going to be sweet

ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants